Delivery-Date: Thu, 07 Aug 2014 10:04:58 -0400
Return-Path: <tor-talk-bounces@lists.torproject.org>
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on moria.seul.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,
	RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD autolearn=ham
	version=3.3.1
X-Original-To: archiver@seul.org
Delivered-To: archiver@seul.org
Received: from eugeni.torproject.org (eugeni.torproject.org [38.229.72.13])
	(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by khazad-dum.seul.org (Postfix) with ESMTPS id CBC6B1E0C88;
	Thu,  7 Aug 2014 10:04:56 -0400 (EDT)
Received: from eugeni.torproject.org (localhost [127.0.0.1])
	by eugeni.torproject.org (Postfix) with ESMTP id 5FF1525D6E;
	Thu,  7 Aug 2014 14:04:53 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by eugeni.torproject.org (Postfix) with ESMTP id 2897425C1A
 for <tor-talk@lists.torproject.org>; Thu,  7 Aug 2014 14:04:50 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at eugeni.torproject.org
Received: from eugeni.torproject.org ([127.0.0.1])
 by localhost (eugeni.torproject.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id rCBKSUB5f3Po for <tor-talk@lists.torproject.org>;
 Thu,  7 Aug 2014 14:04:50 +0000 (UTC)
Received: from whonix.org (whonix.org [92.243.7.197])
 by eugeni.torproject.org (Postfix) with ESMTP id E89EC21AFC
 for <tor-talk@lists.torproject.org>; Thu,  7 Aug 2014 14:04:49 +0000 (UTC)
Received: from 127.0.0.1 (tor-exit-node.dnslab.nl [95.211.229.158])
 by whonix.org (Postfix) with ESMTPSA id 7221B1B5F
 for <tor-talk@lists.torproject.org>; Thu,  7 Aug 2014 16:04:46 +0200 (CEST)
Message-ID: <53E38770.4080304@whonix.org>
Date: Thu, 07 Aug 2014 14:04:32 +0000
From: Patrick Schleizer <patrick-mailinglists@whonix.org>
MIME-Version: 1.0
To: tor-talk@lists.torproject.org
References: <53D727D8.7010902@riseup.net> <53DE3C5D.8020200@whonix.org>
 <20140804204904.GA5462@patternsinthevoid.net>
In-Reply-To: <20140804204904.GA5462@patternsinthevoid.net>
Subject: Re: [tor-talk] using locally installed Tor in TBB
X-BeenThere: tor-talk@lists.torproject.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: tor-talk@lists.torproject.org
List-Id: "all discussion about theory, design,
 and development of Onion Routing" <tor-talk.lists.torproject.org>
List-Unsubscribe: <https://lists.torproject.org/cgi-bin/mailman/options/tor-talk>, 
 <mailto:tor-talk-request@lists.torproject.org?subject=unsubscribe>
List-Archive: <http://lists.torproject.org/pipermail/tor-talk/>
List-Post: <mailto:tor-talk@lists.torproject.org>
List-Help: <mailto:tor-talk-request@lists.torproject.org?subject=help>
List-Subscribe: <https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-talk>, 
 <mailto:tor-talk-request@lists.torproject.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: tor-talk-bounces@lists.torproject.org
Sender: "tor-talk" <tor-talk-bounces@lists.torproject.org>

isis:
> This should be fixed (for Linux) in an upcoming Tor Browser 4.0 release. I've
> added these things to the `start-tor-browser` script. There are:
> 
>     - Instructions for use, including additional Firefox preferences that
>       you'll need to set (to tell Tor Button where your ControlPort and
>       SocksPort are, etc.)
> 
>     - An "easy" spot in the `start-tor-browser` script to put in your
>       ControlPort password so that it is given to the Firefox process (but not
>       exported, because then other programs might be able to steal it)
> 
>     - A line will print to your terminal telling you that you're using a
>       system-installed Tor.
> 
> See #10178, [0] and this commit [1] containing the changes. If you're running
> Linux and would like to test these, nightly builds are available. [2]
> 
> Contributions to improve this, i.e. automatically setting the preferences for
> you, are welcome.
> 
> [0]: https://bugs.torproject.org/10178
> [1]: https://gitweb.torproject.org/builders/tor-browser-bundle.git/commitdiff/a566e85f785c12157283920a179cdc64fdd28b32
> [2]: https://people.torproject.org/~linus/builds/

Hi isis,

thank you for working on this!

Comments on the script / patch:

- You switched from #!/bin/sh to #!/bin/bash. While I personally
preferred to forget about bothering with sh and switching to bash, I
don't there are any systems that only have sh, no bash? (`checkbashisms`
may be helpful.)

- Can you run the script through the code analysis tool `shellcheck`
please? [1] It reports some issues that are worth fixing.

- Wouldn't it be better if the script started Firefox using `exec`? (As
per best scripting practices [4].)

If you wish I could do the changes in a github branch if you would be
willing to review.

All the best,
Patrick

[1] shellcheck [2] is an online service and Libre Software
(downloadable) that detects problems with sh/bash scripts. Also
available in Debian jessie [3] and sid.
[2] http://www.shellcheck.net/
[3] https://packages.debian.org/jessie/shellcheck
[4] http://mywiki.wooledge.org/WrapperScript

-- 
tor-talk mailing list - tor-talk@lists.torproject.org
To unsubscribe or change other settings go to
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-talk

